Skip to content

Conversation

@yahonda
Copy link
Member

@yahonda yahonda commented Oct 31, 2025

What is changed, added or deleted? (Required)

This pull request adds the REORGANIZE PARTITION operation requires metadata lock.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jackysp for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link

Summary of Changes

Hello @yahonda, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the accuracy of the TiDB documentation by explicitly listing the REORGANIZE PARTITION operation among the DDL statements that necessitate a metadata lock. This ensures that users are fully informed about the concurrency implications when performing partition reorganization.

Highlights

  • Documentation Update: The documentation for metadata locks has been updated to include REORGANIZE PARTITION as a DDL statement that requires a metadata lock.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds REORGANIZE PARTITION to the list of DDL statements that require a metadata lock. To enhance readability, I've suggested alphabetically sorting the list of statements. Additionally, please correct the typo in the pull request title from "medata" to "metadata".

@yahonda
Copy link
Member Author

yahonda commented Oct 31, 2025

Here are test scenario to make sure reorganize partition requires metadata lock.

  1. Startup TiDB Playground
% tiup playground # v8.5.3
  1. create events table
% mysql --host 127.0.0.1 --port 4000 -u root test
CREATE TABLE events (
  id INT,
  name VARCHAR(255),
  event_date DATE
)
PARTITION BY RANGE (YEAR(event_date)) (
  PARTITION pBefore1950 VALUES LESS THAN (1950),
  PARTITION p1950      VALUES LESS THAN (1960),
  PARTITION p1960      VALUES LESS THAN (1970),
  PARTITION p1970      VALUES LESS THAN (1980),
  PARTITION p1980      VALUES LESS THAN (1990),
  PARTITION p1990      VALUES LESS THAN (2000),
  PARTITION pMax       VALUES LESS THAN MAXVALUE
);
  1. Open terminal 1
% mysql --host 127.0.0.1 --port 4000 -u root test
prompt t1> 
begin;
INSERT INTO events (id, name, event_date) VALUES (1, 'foo', '1949-12-31');
INSERT INTO events (id, name, event_date) VALUES (2, 'bar', '1959-12-31');
-- Do not commit yet;
  1. Open terminal 2
mysql --host 127.0.0.1 --port 4000 -u root test
prompt t2> 
ALTER TABLE events REORGANIZE PARTITION pBefore1950,p1950 INTO 
(PARTITION pBefore1960 VALUES LESS THAN (1960));
/* this REORGANIZE PARTITION operation wait for the transacion terminal 1*/
  1. Commit the transaction at t1 then the ALTER TABLE events REORGANIZE PARTITION operation t2 will be finished.

@yahonda
Copy link
Member Author

yahonda commented Oct 31, 2025

CleanShot 2025-10-31 at 10 50 07@2x

@qiancai qiancai added type/enhancement The issue or PR belongs to an enhancement. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Nov 3, 2025
@qiancai qiancai self-assigned this Nov 3, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 3, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-03 06:24:49.999869344 +0000 UTC m=+78539.442899222: ☑️ agreed by qiancai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/doing This PR's assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants